Conversation
This was referenced Aug 31, 2026
Contributor
|
@hCoureau Could you fix the conflict? |
Contributor
Author
|
Resolved the merge conflicts with current Validation: 1,026 tests passed, 92 snapshots passed, all pre-commit hooks passed, and sdist/wheel builds passed. GitHub CI was triggered for the new head. Required maintainer approval still applies. The existing stacked dependencies on #936 and #937 still apply; this update does not bypass their review or merge order. Conflict resolution and validation performed with OpenAI Codex assistance. |
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Important
Depends on #937 and #936. Archive obstacles and skip-point tables are preserved with Q10CleanRecordDetail composition. Current upstream is integrated. This branch also includes the separate upstream conformance fix #965 (issue #964); merge that fix first.
Design against the #933 review priorities
Q10Obstaclevalues and the traits only expose defensive list copies; rendering consumes the same typed values.Validation
1006 passed, including92snapshot testsThe implementation was also exercised against a physical Roborock Q10 S5 using position-only obstacle data. No private map captures or account data are included.
Related work
Latest maintenance validation
eac001c; isolated upstream conformance fix tracked in Model conformance test fails on existing frozen Q10RoborockPoint #964 / fix: preserve immutable Q10 points in model conformance checks #965.